Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Manager class implementation #1

Merged
merged 24 commits into from Jun 22, 2022
Merged

Media Manager class implementation #1

merged 24 commits into from Jun 22, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented May 18, 2022

Design doc: https://g0v.hackmd.io/@mrorz/cofacts-media-manager

Implements:

  • types
  • MediaManager class constructor, .query(), .insert(), .getContent(), .getInfo() for files, video and audio
  • Integration test for above APIs for file, which involves a file server that serves the input URL, and credential settings for GCS

MrOrz added 4 commits May 24, 2022 01:28
resp.clone() will mutate resp.body.
If resp.body is stored before resp.clone() is called, pipe will stuck because the new body (after clone()) is not consuming data.
- file can be uploaded as expected
- returned URL is valid and accessible
- TODO: resolve before full file is resolved
MrOrz added 11 commits May 24, 2022 15:10
- it does not wait for upload to complete
- it deletes temp file if name in the ID hash already exist
- ai/size-limit does not support nodejs
- esbuild used by size-limit do support NodeJS platform, but ai/size-limit does not provide API for us to set esbuild config
- It does not really make sense to limit the size of a nodejs package
- 100KB is large enough to fill Node.JS stream's high watermark and cause stream to halt if streams are not connected correctly.
- I found that smaller files (50KiB) will work even if I connected the streams incorrectly (ex: retrieve body stream before clone()); when 100KiB is used, stream is blocked as expected. Thus 100KiB is chosen.
to keep it small and more focused on logic
@MrOrz MrOrz marked this pull request as ready for review May 27, 2022 12:41
@MrOrz MrOrz requested a review from nonumpa May 27, 2022 12:56
src/lib/prepareStream.ts Outdated Show resolved Hide resolved
@MrOrz MrOrz requested a review from nonumpa June 13, 2022 02:55
@MrOrz MrOrz merged commit 16007ef into main Jun 22, 2022
@MrOrz MrOrz deleted the media-manager-cls branch June 22, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants