New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Manager class implementation #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also implements ID generation & parsing
resp.clone() will mutate resp.body. If resp.body is stored before resp.clone() is called, pipe will stuck because the new body (after clone()) is not consuming data.
- file can be uploaded as expected - returned URL is valid and accessible - TODO: resolve before full file is resolved
- it does not wait for upload to complete - it deletes temp file if name in the ID hash already exist
- ai/size-limit does not support nodejs - esbuild used by size-limit do support NodeJS platform, but ai/size-limit does not provide API for us to set esbuild config - It does not really make sense to limit the size of a nodejs package
- 100KB is large enough to fill Node.JS stream's high watermark and cause stream to halt if streams are not connected correctly. - I found that smaller files (50KiB) will work even if I connected the streams incorrectly (ex: retrieve body stream before clone()); when 100KiB is used, stream is blocked as expected. Thus 100KiB is chosen.
to keep it small and more focused on logic
Or file will be cleared
nonumpa
reviewed
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc: https://g0v.hackmd.io/@mrorz/cofacts-media-manager
Implements:
MediaManager
class constructor,.query()
,.insert()
,.getContent()
,.getInfo()
for files, video and audio